Angel Pons has uploaded this change for review.

View Change

drivers/pc80/pc/i8259c: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: I5bafcda2f8958e1ea4467749b40802deebe1cd3a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M src/drivers/pc80/pc/i8259.c
1 file changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/43211/1
diff --git a/src/drivers/pc80/pc/i8259.c b/src/drivers/pc80/pc/i8259.c
index 1126f14..c6aaef3 100644
--- a/src/drivers/pc80/pc/i8259.c
+++ b/src/drivers/pc80/pc/i8259.c
@@ -108,18 +108,4 @@
/* Write new values */
outb((u8)(int_bits & 0xff), ELCR1);
outb((u8)(int_bits >> 8), ELCR2);
-
-#ifdef PARANOID_IRQ_TRIGGERS
- /* Try reading back the new values. This seems like an error
- * but it is not. */
- if (inb(ELCR1) != (int_bits & 0xff)) {
- printk(BIOS_ERR, "%s: lower order bits are wrong: want 0x%x, got 0x%x\n",
- __func__, (int_bits & 0xff), inb(ELCR1));
- }
-
- if (inb(ELCR2) != (int_bits >> 8)) {
- printk(BIOS_ERR, "%s: higher order bits are wrong: want 0x%x, got 0x%x\n",
- __func__, (int_bits>>8), inb(ELCR2));
- }
-#endif
}

To view, visit change 43211. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bafcda2f8958e1ea4467749b40802deebe1cd3a
Gerrit-Change-Number: 43211
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: newchange