Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74111 ) Change subject: mb/google/myst: Enable AP <-> GSC communication ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74111/comment/1c79e7f1_111ae4d4 PS16, Line 219: __weak void variant_espi_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) : { : *size = ARRAY_SIZE(espi_gpio_table); : *gpio = espi_gpio_table; : __weak void variant_tpm_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) : { : *size = ARRAY_SIZE(tpm_gpio_table); : *gpio = tpm_gpio_table; : } Bad merge here. -- To view, visit https://review.coreboot.org/c/coreboot/+/74111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117 Gerrit-Change-Number: 74111 Gerrit-PatchSet: 16 Gerrit-Owner: Jon Murphy <jpmurphy@google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy@google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Attention: Mark Hasemeyer <markhas@google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:43:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment