So before this discussion peters out because nobody wants to respond anymore, I will revert this change (and the Documentation/coding_style.md one). We cannot argue for weeks whether this was/is/should be the right thing to do or not while it already affects all submissions going in. The justification for this in the commit message was "80 chars + 2 tabs was the compromise we got in the last round of discussion", which is simply not true. The policy for bad changes is revert first, sort it out later.

Reverts at CB:31915 and CB:31916

I would strongly suggest to continue this discussion on the mailing list so that all coreboot developers have a chance to join in. I would also suggest to separate the issues of line length and using/forcing clang-format, because both are controversial and it gets very confusing when the discussion keeps going back and forth across both.

View Change

To view, visit change 31651. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9293a69d1bea900da36501cde512004d0695ad37
Gerrit-Change-Number: 31651
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-CC: ron minnich
Gerrit-Comment-Date: Fri, 15 Mar 2019 22:54:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment