Incorporated feedback and uploaded the changes. Also updated Documentation/releases/coreboot-4.13.relnotes.md.
Thank you for testing and providing feedback everybody!
13 comments:
No need
So no changes that I need to make here?
Patch Set #2, Line 129: server
Agreed, this works even on non-server stuff
Done
Patch Set #4, Line 734: __func__, cpu);
Fits on the previous line (line length limit is 96 characters)
Done
File src/cpu/x86/smm/smm_module_loaderv2.c:
Patch Set #2, Line 15: uint8_t
*poke* […]
This is same as previous loader, so I didn't change anything. I left it as is.
Patch Set #2, Line 51: unsigned int
*poke*
done
Patch Set #2, Line 108: printk(BIOS_ERR, "%s: unable to get SMM module size\n", __func__);
*poke*
No, we should not continue. Good catch. I've made the fix by adding a return 0 there.
Patch Set #2, Line 112: 0xFFFF
*poke*
Yes, this can be confusing. It means 64K segment. I've now added a clarification in the above comment line.
Patch Set #2, Line 123: not enough space in SMM to setup all CPUs
*poke*
A developer would have to read the Intel Software Developer's Manuals and the datasheet of the specific SOC to determine how much SMRAM is supported. This is based on various features available in the HW.
Patch Set #2, Line 213: unsigned int
*poke*
Done
Patch Set #2, Line 226: params->smm_main_entry_offset < stack_top) {
*poke*
Done
Patch Set #2, Line 231: __func__, cpus[num_cpus].smbase, stack_top);
*poke*
Done
Patch Set #2, Line 604: "%s: need more SMRAM\n", __func__);
*poke* […]
Done
File src/include/cpu/x86/smm.h:
Patch Set #2, Line 152: #if CONFIG(X86_SMM_LOADER_VERSION2)
*poke*
Done
To view, visit change 43684. To unsubscribe, or for help writing mail filters, visit settings.