Attention is currently required from: Benjamin Doron.
Patch set 2:-Code-Review
View Change
2 comments:
Commit Message:
Patch Set #2, Line 15: Note that this breaks flashconsole, since the flash becomes read-only.
Add this to Kconfig help text?
Done
Patch Set #2, Line 17: Tested on Asrock B85M Pro4, SMM protection works as expected.
I meant platforms using SOC_INTEL_COMMON_PCH_LOCKDOWN, which is most of soc/intel/*lake.
I've removed the option for soc/intel platforms, for now. Once CB:50754 fixes the SMI# handler bugs, I'll re-add the option.
To view, visit change 40830. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I157db885b5f1d0f74009ede6fb2342b20d9429fa
Gerrit-Change-Number: 40830
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:48:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment