Attention is currently required from: Martin Roth, Jakub Czapiga, Angel Pons.
View Change
1 comment:
File tests/Makefile.inc:
Patch Set #4, Line 164: clean-unit-tests
I added a 'clean' here because if some of the code has already been built without gcov, it will cause build errors. At least for the first iteration of building coverage, I think we want coverage over all of the unit tests. Later, when we add options to build coverage just for one test, we can revisit building the code into a separate build directory so that we don't have to clean when switching between coverage and no-coverage.
To view, visit change 52444. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ea780ee9e246c0bb8c35b8e0de4252431dabbff
Gerrit-Change-Number: 52444
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 03 May 2021 23:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment