Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu, Wonkyu Kim.

Jérémy Compostella uploaded patch set #10 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by Wonkyu Kim, Verified+1 by build bot (Jenkins)

drivers/intel/fsp2_0: Support FSP 2.4 64-bits

FSP 2.4 brings FSP 64-bits support which requires some adjustments in
coreboot:

- Stack alignment:

  1. FSP functions must be called with the stack 16-bytes aligned.
     This is already setup properly with the default value of the
     `mpreferred-stack-boundary' compiler option (4).

  2. The FSP stack buffer supplied by coreboot through the `StackBase'
     UPD must be 16-bytes aligned.

- The EDK2 EFIAPI macro definition relies on compiler flags such as
  __GNUC__ which is not working well when included by coreboot. While it
  has no side-effect on i386 because the C calling convention used by
  coreboot and FSP are the same, it breaks on x86_64 because FSP/UEFI
  uses the Microsoft x64 calling convention while coreboot uses the
  System V AMD64 ABI.

  Fortunately, EDK2 header allows to override the EFIAPI
  definition.

  This appropriate attribute has to be set to all functions calling or
  called by the FSP.

- Add fsp print helper macros to print `efi_return_status_t' with the
  appropriate format

TEST=verified on Lunar Lake RVP board (lnlrvp)

Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
---
M src/drivers/intel/fsp2_0/debug.c
M src/drivers/intel/fsp2_0/fsp_debug_event.c
M src/drivers/intel/fsp2_0/include/fsp/debug.h
M src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h
M src/drivers/intel/fsp2_0/include/fsp/info_header.h
M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h
M src/drivers/intel/fsp2_0/include/fsp/util.h
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service1.c
M src/drivers/intel/fsp2_0/ppi/mp_service2.c
M src/drivers/intel/fsp2_0/silicon_init.c
M src/drivers/intel/fsp2_0/util.c
M src/include/efi/efi_datatype.h
M src/soc/amd/common/fsp/fsp_reset.c
M src/soc/intel/common/fsp_reset.c
15 files changed, 93 insertions(+), 63 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/80277/10

To view, visit change 80277. To unsubscribe, or for help writing mail filters, visit settings.