2 comments:
File payloads/libpayload/include/sysinfo.h:
Patch Set #9, Line 111: UNDEFINED_FW_CONFIG
Is the payload expected to test whether the fw_config is all 1s before treating it as a valid value? One special thing about fw_config compared to the other IDs is that it is a bit-field member and so the payload will have to be careful about treating all 1s as all 0s. Should we just set the UNDEFINED_FW_CONFIG as all 0s instead here?
File src/lib/coreboot_table.c:
Patch Set #9, Line 222: if (bid == UNDEFINED_STRAPPING_ID)
One slight change in behavior with the new code is that all the IDs are now added to coreboot tables even if the value is UNDEFINED_STRAPPING_ID. I am guessing there are no side-effects of doing that?
To view, visit change 46605. To unsubscribe, or for help writing mail filters, visit settings.