29 comments:
Since it's not trivial to me, could you mention how the code is "refactored" (by moving between file […]
Done
File src/soc/mediatek/common/rtc.c:
Does 0 mean success or failure here?
0 here means failure.
This is consistent in the rtc coreboot driver
File src/soc/mediatek/common/rtc_osc_init.c:
Patch Set #51, Line 4: #include <soc/rtc.h>
rtc.h should come before rtc_common. […]
Done
Patch Set #51, Line 9: diff1, diff2
diff_left, diff_right
Done
No need to initialize this and "middle".
Done
%#x
Done
Remove extra blank line.
Done
if (val > RTC_FQMTR_LOW_BASE)
diff1 = val - RTC_FQMTR_LOW_BASE;
else
diff1 = RTC_FQMTR_LOW_BASE - val;
This can be simplified to […]
Ack
One space after ":"
Done
Please be consistent with the case (C or c).
Done
File src/soc/mediatek/mt8173/include/soc/rtc.h:
failed
Done
failed
Done
File src/soc/mediatek/mt8173/rtc.c:
No period for consistency with comments above.
Ack
I
Done
w
Done
File src/soc/mediatek/mt8183/include/soc/rtc.h:
failed
Done
failed
Done
File src/soc/mediatek/mt8183/rtc.c:
Patch Set #51, Line 228: /* in recovery mode, We need 20ms delay for register setting. */
Same.
Done
File src/soc/mediatek/mt8192/include/soc/rtc.h:
Could you add a "," for all the enums in this file?
Done
Patch Set #51, Line 89: to low
low
Ack
Patch Set #51, Line 89: lower leakage current hw design change
What does that mean?
Ack
File src/soc/mediatek/mt8192/rtc.c:
Patch Set #51, Line 21: (unsigned int)
Do we need the cast? Same below. […]
Done
Patch Set #51, Line 46: /* Unlock for reload */
Move to its own line.
Ack
%#x
Done
Patch Set #51, Line 136: out !!
out!
Done
If this is boolean, please use native type such as int.
Done
I
Done
w
Done
%#x […]
Done
To view, visit change 46395. To unsubscribe, or for help writing mail filters, visit settings.