Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
intel/dcp847ske: use functions from hwm5_conf.h for HWM setup

Change-Id: I67de5260a756fc7b1cf0ec1903bee0058a2dcb06
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35861
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
---
M src/mainboard/intel/dcp847ske/superio.h
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/intel/dcp847ske/superio.h b/src/mainboard/intel/dcp847ske/superio.h
index 56938e7..6f74d3e 100644
--- a/src/mainboard/intel/dcp847ske/superio.h
+++ b/src/mainboard/intel/dcp847ske/superio.h
@@ -18,6 +18,7 @@
#define DCP847SKE_SUPERIO_H

#include <arch/io.h>
+#include <superio/hwm5_conf.h>

#define NUVOTON_PORT 0x4e
#define HWM_PORT 0x0a30
@@ -44,11 +45,6 @@

#define SUPERIO_WRITE_INITVAL(val) SUPERIO_WRITE((val) >> 8, (val) & 0xff)

-#define HWM_WRITE(reg, data) do { \
- outb((reg), HWM_PORT + 5); \
- outb((data), HWM_PORT + 6); \
-} while (0)
-
-#define HWM_WRITE_INITVAL(val) HWM_WRITE((val) >> 8, (val) & 0xff)
+#define HWM_WRITE_INITVAL(val) pnp_write_hwm5_index(HWM_PORT, (val) >> 8, (val) & 0xff)

#endif /* DCP847SKE_SUPERIO_H */

To view, visit change 35861. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67de5260a756fc7b1cf0ec1903bee0058a2dcb06
Gerrit-Change-Number: 35861
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged