Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu.
Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72749 )
Change subject: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0 ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72749/comment/9fa6b520_0d067385 PS1, Line 7: power on
power-on
Done
https://review.coreboot.org/c/coreboot/+/72749/comment/9611e5ae_c559955a PS1, Line 9: Add power sequence to power on BOE_TV110C9M_LL0 on Geralt proto board.
For Geralt, we use BOE_TV110C9M_LL0 as mipi firmware display, so […]
Done
https://review.coreboot.org/c/coreboot/+/72749/comment/d663e651_7bdb240a PS1, Line 12: on Geralt proto : board
on Geralt.
Done
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/72749/comment/35ab73e8_39a0bd99 PS1, Line 22: static int mipi_panel_reg_mask (u8 addr, u8 val, u8 mask)
move to panel.c.
Done
https://review.coreboot.org/c/coreboot/+/72749/comment/a8aa8f3e_87750746 PS1, Line 26: if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) : printk(BIOS_ERR, "Rex: failed to read i2c: %d\n", addr);
` […]
Done
https://review.coreboot.org/c/coreboot/+/72749/comment/30ca66fb_3d16d88d PS1, Line 66: ret = mipi_panel_reg_mask(0x00, 0x11, 0x1F); : : /* Set AVEE = -5.7V */ : ret = mipi_panel_reg_mask(0x01, 0x11, 0x1F); : : /* Disable AVDD & AVEE discharge when power on*/ : ret = mipi_panel_reg_mask(0x03, 0x30, 0xFF);
do some error handling
Done
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/72749/comment/433f58aa_c21823e6 PS3, Line 51: mt6359p_init
mt6359 has been initialized in romstage. Can we just initialize it only once? […]
Done