20 comments:
File src/soc/intel/alderlake/Makefile.inc:
Please keep entries sorted in alphabetical order
Ack
File src/soc/intel/alderlake/acpi.c:
Patch Set #3, Line 23: #include <string.h>
Untrue. `memcpy` appears in this file. […]
Ack
Patch Set #3, Line 181: uintptr_t pmc_bar = soc_read_pmc_base();
no need for a temporary variable
Ack
Patch Set #3, Line 188: uint64_t gfxvtbar = MCHBAR64(GFXVTBAR) & VTBAR_MASK;
Many things here can be const
Ack
Patch Set #3, Line 233: TBT0BAR
You could redefine these registers as follows: […]
Ack
/* Add RMRR entry */
const unsigned long tmp = current;
current += acpi_create_dmar_rmrr(current, 0,
sa_get_gsm_base(), sa_get_tolud_base() - 1);
current += acpi_create_dmar_ds_pci(current, 0, 2, 0);
acpi_dmar_rmrr_fixup(tmp, current);
Shouldn't this be skipped if the IGD is disabled?
Ack
File src/soc/intel/alderlake/chip.c:
Patch Set #3, Line 3: #include <console/console.h>
not used?
Ack
Patch Set #3, Line 118: rotine
ro*u*tine
Ack
/* Snapshot the current GPIO IRQ polarities. FSP is setting a
* default policy that doesn't honor boards' requirements. */
itss_snapshot_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END);
Does this still apply to ADL?
so far yes, we have bug filled and mostly its early FSP hence scope for improvement is here
File src/soc/intel/alderlake/include/soc/cpu.h:
Patch Set #3, Line 6: #include <intelblocks/msr.h>
not used. […]
Ack
File src/soc/intel/alderlake/include/soc/me.h:
<stdint. […]
Ack
File src/soc/intel/alderlake/include/soc/ramstage.h:
Patch Set #3, Line 6: #include <device/device.h>
not used?
Ack
File src/soc/intel/alderlake/lockdown.c:
Patch Set #3, Line 16: uint8_t
<stdint. […]
Ack
File src/soc/intel/alderlake/pmc.c:
Patch Set #3, Line 25: uint8_t
<stdint. […]
Ack
File src/soc/intel/alderlake/pmutil.c:
Patch Set #3, Line 39: size_t
<stddef. […]
Ack
Patch Set #3, Line 123: uint8_t
<stdint. […]
Ack
<types. […]
Ack
File src/soc/intel/alderlake/smihandler.c:
Patch Set #3, Line 3: console/console.h>
not used?
Ack
File src/soc/intel/alderlake/smmrelocate.c:
Patch Set #3, Line 3: #include <types.h>
I prefer to keep #includes sorted alphabetically.
Done. thanks
File src/soc/intel/alderlake/soundwire.c:
Patch Set #3, Line 48: size_t
<stddef. […]
Ack
To view, visit change 45759. To unsubscribe, or for help writing mail filters, visit settings.