Attention is currently required from: Sean Rhodes, Michał Żygowski, Martin Roth, Jakub Czapiga, Matt DeVillier, Patrick Rudolph.
View Change
2 comments:
Commit Message:
Patch Set #5, Line 18: - Init store with FVH when blank
Yes, I think coreboot should initialize it. […]
Updated the commit message with more information. Is that fine for you?
Patch Set #5, Line 20: - Reclaim memory when store is full
The store is write-append. You write a new variable at the end and mark the old as "deleted". […]
Updated the commit message with more information. Is that fine for you?
To view, visit change 52564. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Sean Rhodes <sean@starlabs.systems>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 09:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment