Patch Set 1:

Patch Set 1:

Patch Set 1:

I'd keep them.

Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here

I guess because of CB:25565 (which would have to uncomment the entries anyway)

Ah, I see. Elyes, if you resurrect CB:25565, would you be OK with just adding those Kconfig options back in with that patch?

View Change

To view, visit change 44218. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fc53fea4225217bc5bb70d839c280ebb64fd3a6
Gerrit-Change-Number: 44218
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 05 Aug 2020 19:16:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment