Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
agogo has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )
Change subject: soc/mediatek/mt8196: Initialize MCUPM ......................................................................
Patch Set 7:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85888/comment/141de806_5170d2c5?usp... : PS6, Line 17: TEST=Build pass and we can see the mcupm logs after reset releases.
Please paste the new logs.
It is the debug log printed by MCUPM FW bin. Default is disable.
File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:
https://review.coreboot.org/c/coreboot/+/85888/comment/898d3508_0c70b873?usp... : PS6, Line 69: POLLING_MCU_TIME
@jarried.lin@mediatek. […]
Done
https://review.coreboot.org/c/coreboot/+/85888/comment/932f5a20_cd3860e5?usp... : PS6, Line 79: 0x4
Hex notation not necessary?
I don't think it is necessary to modify.
File src/soc/mediatek/mt8196/mcupm.c:
https://review.coreboot.org/c/coreboot/+/85888/comment/33c3304a_8d13867a?usp... : PS6, Line 17: POLLING_MCU_TIME
No, the usage is correct.
Done
https://review.coreboot.org/c/coreboot/+/85888/comment/3f34b1d0_51142f45?usp... : PS6, Line 21: "[EB_SPMC] Polling MCU_PORT_SET_R0_0 timeout, %#x\n",
I don't think that is necessary. […]
Done
https://review.coreboot.org/c/coreboot/+/85888/comment/4051bf8c_dc29d7c6?usp... : PS6, Line 72: int ret = 0;
Does not need to be initialized.
Done
https://review.coreboot.org/c/coreboot/+/85888/comment/df853fea_689e8822?usp... : PS6, Line 80: ret = eb_spmc_spm();
Return right away?
I don't think it is necessary to modify. It's easier to read and maintain.