build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: [WIP] intel/skylake: Implement PCIe RP devicetree update based on DID
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35985/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/35985/5/src/soc/intel/common/block/...
PS5, Line 33: void pcie_rp_update_devicetree(const struct pcie_rp_mapper *);
function definition argument 'const struct pcie_rp_mapper *' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib17d2b6fd34608603db3936d638bdf5acb46d717
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Oct 2019 16:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment