Reworked based on comments, EC is now in a subdirectory, io port addresses are provided in devicetree, using an fmap to reserve space for the EC firmware (and copying it in using cbfstool rather than using a separate utility), using generic HDA code. Tested as working.
7 comments:
Patch Set #8, Line 10: firmware protection
What does this refer to? Is the IFD fully unlocked? Are all protected ranges unset? Does it not use […]
Done
EC firmware is contained within the system SPI flash, and so a blob of
EC firmware must be injected to a defined location during image build.
I would suggest using a fmap to define this location. […]
Done
I'd suggest listing what works/does not work/is untested.
Done
Patch Set #8, Line 43: 0x00200000
Is that the beginning of the BIOS region? Some other different Nuvoton EC I have has the firmware at […]
Done
Patch Set #8, Line 20: #define SETUP_COMMAND 0x4e
I recall seeing 0x4e/0x4f somewhere else... […]
Done
File src/mainboard/51nb/x210/acpi/ec.asl:
Patch Set #8, Line 126: Device (BAT)
Maybe this could go in acpi/battery. […]
Done
File src/mainboard/51nb/x210/mainboard.c:
Patch Set #8, Line 57: /* Route 0x4e/4f to LPC */
Ah, this is what I recall 0x4e/0x4f from.
Done
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.