Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML ......................................................................
Patch Set 7:
(3 comments)
Please don't draw every cosmetic change in FSP UPDs into our devicetrees. It makes things messy and in- compatible.
I don't object to such changes in general. But please ask your FSP team to do such cleanups to all FSP plat- forms in parallel so FSP users don't have to suffer.
CNL code base is there since 2016-17 time if i'm not wrong and we are in 2019, still making use of CNL code base for adding close possible platforms. Because coreboot touches very less Silicon programming and leave remaining on FSP. Consider the fact that intel FSP has wide range of customer from different OS background since CNL till now, every one not using this coreboot code base and FSP is not ideally "only" written to support coreboot hence expectation is wrong that FSP would consider all coreboot platform change and make an unified FSP header file so that all coming platform going to consume the same. I don't have problem with setting the expectation but just highlighting the reality.
And more over if you have concern that "your" devicetree is populated with FSP changes then we can come up with better planning in future and clean up that code. Anyway we are targeting for common code 2.0 soon FYI.