Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Jianjun Wang.

Patch set 4:Code-Review +1

View Change

2 comments:

• File src/commonlib/bsd/include/commonlib/bsd/helpers.h:

  • Patch Set #1, Line 129: ARCH_X86

    I only have the environment for cherry board, and have no idea how to build for x86 platform, could […]

    So, there are still errors for PS4 (see Jenkins build console):

     In file included from src/soc/intel/common/block/fast_spi/fast_spi.c:15:
     src/include/lib.h:57:19: error: conflicting types for 'fls'; have 'int(u32)' {aka 'int(unsigned int)'}
        57 | static inline int fls(u32 x) { return 32 - clz(x); }
           |                   ^~~
     In file included from src/arch/x86/include/arch/romstage.h:8,
                      from src/soc/intel/common/block/fast_spi/fast_spi.c:5:
     src/include/cpu/x86/mtrr.h:167:28: note: previous definition of 'fls' with type 'unsigned int(unsigned int)'
       167 | static inline unsigned int fls(unsigned int x)
           |                            ^~~

    Following Julius' suggestion to rename to __fls() would probably solve the problem.

  • Patch Set #1, Line 137: fls

    Sure, is there any document can tell how to do the unit tests?

    See CB:56543 as an example. Tests can be run by

     make unit-tests

To view, visit change 59738. To unsubscribe, or for help writing mail filters, visit settings.