Patch Set 58: Code-Review+1

After re-testing this on my A88XM-E I'm going to vote +2 for this Balazs change: hope it's acceptable to do, despite I've spent so much time on this code.

It's a 4 eyes principle, not a "must have never worked on the code" principle (although it's better to have an independent reviewer, of course). This really went through lots of iterations, so if you two agree that this is the way to go and even get to test it successfully, and there aren't any objection, I'll happily get it in.

As for the missed 4.12 release: add a note to the 4.13 release notes (already in the tree) and it will get a more visible shout out then than it would have gotten with the 4.12 release (where I didn't mention new boards by name).

View Change

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 58
Gerrit-Owner: Balázs Vinarz <vinibali1@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 13 May 2020 14:05:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment