3 comments:
File src/mainboard/google/hatch/variants/baseboard/memory.c:
/* Access memory info using the spd file specified by spd_index */
.spd = {.read_type = READ_SPD_CBFS},
I think its better to set this and spd_index in romstage. […]
I moved it to variant_memory_params() below because the per-slot spd info has dependence on whether single channel or not.
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
if (!cnl_cfg->spd.spd_spec.spd_smbus_address[i])
continue;
Do we need this check? If the user is explicitly setting READ_SMBUS now, we should just copy whateve […]
Removed
Patch Set #3, Line 121: printk
Probably add a die here? since this should not occur in production, but should be caught in developm […]
Done
To view, visit change 32513. To unsubscribe, or for help writing mail filters, visit settings.