2 comments:
Patch Set #3, Line 7: /Makefile.inc
you don't need to mention the filename, directory is good enough
File src/security/vboot/Makefile.inc:
$(if $(filter \
$(if $(filter y,$(CONFIG_VBOOT_STARTS_IN_ROMSTAGE)), \
%/romstage,) \
mts \
%/verstage \
locales \
locale_%.bin \
font.bin \
vbgfx.bin \
rmu.bin \
cmos_layout.bin \
cmos.default \
$(call strip_quotes,$(CONFIG_RO_REGION_ONLY)) \
,$(1)),COREBOOT,\
$(if $(filter \
$(call strip_quotes,$(CONFIG_RWA_REGION_ONLY)) \
,$(1)), FW_MAIN_A, \
$(if $(filter \
$(call strip_quotes,$(CONFIG_RWB_REGION_ONLY)) \
,$(1)), FW_MAIN_B, \
$(if $(filter \
$(call strip_quotes,$(CONFIG_RW_REGION_ONLY)) \
,$(1)), $(RW_PARTITIONS), $(VBOOT_PARTITIONS) ) \
))))))
I think this can be shifted left one tab, the `$(if $(filter \` should line up with `$(regions-for-file-$(1)), \`
To view, visit change 43766. To unsubscribe, or for help writing mail filters, visit settings.