Patch Set 3:

1M is really a lot and wouldn't fit in most ramstages. Is that much heap really needed or should the linker scripts be adapted?

It's lib/malloc.c, just print (uintptr_t)free_mem_end_ptr - (uinptr_t)free_mem_ptr before entry to payload to find out actual usage. Doing that in payload_run() after checkstack() would make some sense in any case.

While HEAP_SIZE is adjusted based on FLATTENED_DEVICE_TREE (and lib/device_tree.c), maybe majority of heap requirement comes from PAYLOAD_FIT_SUPPORT, unpack_fdt() in lib/fit_payload.c instead.

IMHO it is not particularly clean if payload does references back to ramstage heap.

View Change

To view, visit change 32392. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id17f25e94d97e937b0e9a9cee3dd1a8aef1d525d
Gerrit-Change-Number: 32392
Gerrit-PatchSet: 3
Gerrit-Owner: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 14 Sep 2019 16:21:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment