6 comments:
File src/mainboard/google/kukui/Kconfig:
Patch Set #4, Line 68: config SSPM_BIN_FILE
Still think this shouldn't be a Kconfig...
File src/mainboard/google/kukui/Makefile.inc:
Patch Set #4, Line 32: sspm-compression := $(CBFS_COMPRESS_FLAG)
Odd that you said you weren't compressing it anymore now? Because this definitely looks like you do (and you should, compression is almost certainly a much bigger speed gain than what a memcpy or two would cost).
File src/mainboard/google/kukui/mainboard.c:
Patch Set #4, Line 41: static void configure_sspm(void)
nit: You don't really need single line functions, can just put sspm_init() into mainboard_init().
File src/soc/mediatek/mt8183/sspm.c:
Make that bool?
Probably better to just die() if something goes wrong, assuming the board cannot really boot without this anyway?
Patch Set #4, Line 35: BIOS_DEBUG
Make that INFO?
I'd say at least ERR, but probably a die()
Patch Set #4, Line 38: "sspm[0]=%#x, [%zd]=%#x\n",
nit: I'm not sure this is useful enough to keep in here after you're done debugging?
To view, visit change 31516. To unsubscribe, or for help writing mail filters, visit settings.