The Asus P8Z77-V LX2 is also in the tree, if you want to use it as a reference
Patch set 6:Code-Review +1
27 comments:
Patch Set #1, Line 12: Does not yet boot. Submitting for eyeballs and help.
Any logs?
Ack
File src/mainboard/asus/p8z77-m/Kconfig:
Patch Set #4, Line 21: select INTEL_INT15
This option is for the code in mainboard.c, which got removed. […]
Done
File src/mainboard/asus/p8z77-m/Kconfig:
Use SPDX here as well
File src/mainboard/asus/p8z77-m/Kconfig.name:
SPDX here as well (or drop the copyright notices, we don't usually have them on these files)
File src/mainboard/asus/p8z77-m/Makefile.inc:
Also SPDX
File src/mainboard/asus/p8z77-m/acpi_tables.c:
Patch Set #5, Line 8: shutdown
shut down
Done
PC
Done
CPU
Done
File src/mainboard/asus/p8z77-m/board_info.txt:
Patch Set #4, Line 6: Flashrom support: ?
Yes, bitbanging SPI is a bit slow. […]
Done
File src/mainboard/asus/p8z77-m/cmos.default:
This should be SPDX
File src/mainboard/asus/p8z77-m/cmos.layout:
SPDX here as well
File src/mainboard/asus/p8z77-m/devicetree.cb:
SPDX here as well
Patch Set #6, Line 44: device pci 14.0 on end # USB 3.0 Controller
I like aligning the "end" words with an extra space on the "on" lines
Patch Set #6, Line 51: device pci 1c.0 on end # PCIe Port #1
What's on each PCIe root port? e.g.:
device pci 1c.5 on end # PCIe Port #6: Realtek RTL8111 GbE NIC
Patch Set #6, Line 98: SATA Controller 1
SATA Controller (AHCI)
Patch Set #6, Line 100: SATA Controller 2
SATA Controller (Legacy)
File src/mainboard/asus/p8z77-m/dsdt.asl:
Patch Set #5, Line 4: // define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Still there!
Done
File src/mainboard/asus/p8z77-m/dsdt.asl:
Patch Set #6, Line 25: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Not needed anymore
File src/mainboard/asus/p8z77-m/early_init.c:
Patch Set #6, Line 34: { 1, 2, 4 }, /* Port 9: USB2 internal header USB910, bottom */
My OCD would appreciate an extra space before the single-digit numbers for alignment purposes
Patch Set #6, Line 59: ARRAY_SIZE(register_values)
You can put this inside the loop
strictly speaking, size_t
Patch Set #6, Line 68: Doing it this way saves a config state re-entry.
Not sure if it's worth the hassle, though
Patch Set #6, Line 113: struct pei_data pd = {
I think it's better to set the non-default fields directly:
pei_data->spd_addresses = { 0xa0, 0xa2, 0xa4, 0xa6 };
Patch Set #6, Line 131: Asus 2203 bios shows XUECA016, but no EC
It's a desktop board, these don't use an EC (Embedded Controller)
These comments should start like this:
/*
* foo bar ...
File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
Patch Set #5, Line 12: FIXME
Fixed already, I guess?
Done
nit: it's a desktop mainboard, it is assumed that all video ports will be on its rear side
Done
To view, visit change 38988. To unsubscribe, or for help writing mail filters, visit settings.