Attention is currently required from: Furquan Shaikh, Aaron Durbin.
Julius Werner would like Furquan Shaikh and Aaron Durbin to review this change.
verstage: Add debug print when returning from verstage
RETURN_FROM_VERSTAGE is a somewhat tricky construct that we don't
normally do otherwise in coreboot. While it works remarkably well in
general, new development can lead to unintentional interactions with
confusing results. This patch adds a debug print to the verstage right
before returning to the bootblock so that it's obvious this happens,
because otherwise in some cases the last printout in the verstage is
about some TPM commands which can be misleading when execution hangs
after that point.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I9ca68a32d7a50c95d9a6948d35816fee583611bc
---
M src/security/vboot/verstage.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/52086/1
diff --git a/src/security/vboot/verstage.c b/src/security/vboot/verstage.c
index d2a9705..d785e0e 100644
--- a/src/security/vboot/verstage.c
+++ b/src/security/vboot/verstage.c
@@ -19,6 +19,7 @@
if (CONFIG(VBOOT_RETURN_FROM_VERSTAGE)) {
verstage_main();
+ printk(BIOS_DEBUG, "VBOOT: Returning from verstage.\n");
} else {
run_romstage();
hlt();
To view, visit change 52086. To unsubscribe, or for help writing mail filters, visit settings.