Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Martin L Roth, Matt DeVillier, Paul Menzel, Raul Rangel, ritul guru.

View Change

7 comments:

• Commit Message:

  • Patch Set #31, Line 16: See AMD document 55570 revision 3.16 for additional details.

    Is this public or NDA? Please mention this both here and below.

• File src/soc/amd/common/block/psp/Kconfig:

  • Patch Set #31, Line 23: default n

    This can probably be left out. By adding it, the default gets set, and nothing loaded after this can change it. If this line is not included, other Kconfig files loaded afterwards have the opportunity to set the default. If nothing sets it, the default value is 'n'.

    Typically, if you want a default of 'n' it's best just to leave out the default line.

• File src/soc/amd/common/block/psp/psp_def.h:

  • Patch Set #31, Line 32:

    Nit: Add a couple more tabs?

• File src/soc/amd/common/block/psp/psp_gen2.c:

  • Patch Set #31, Line 119: static bool is_valid_psp_spi_id(u64 id)

    Put these in a separate file that's only pulled in when we're using PSP SPI code?

• File src/soc/amd/common/block/psp/psp_p2c.c:

  • Patch Set #31, Line 2: #include <device/mmio.h>

    Nit: add an additional line under the SPDX header?

• File src/soc/amd/common/block/spi/Kconfig:

  • Patch Set #23, Line 104: SOC_AMD_COMMON_BLOCK_SPI_ALT

    This is when there is alternative SPIROM (dual SPIROM), which contains a backup of original SPI or a […]

    So this isn't SMM specific? Can it go into a separate commit?

• File src/soc/amd/stoneyridge/include/soc/smi.h:

  • Patch Set #31, Line 74:

    Align

To view, visit change 65523. To unsubscribe, or for help writing mail filters, visit settings.