Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85237?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: [WIP] soc/amd/common/psp: add delay after boot done command in PSP SMI case ......................................................................
[WIP] soc/amd/common/psp: add delay after boot done command in PSP SMI case
When the PSP SMI support is enabled, the PSP might send PSP SMI commands to the SMI handler to access the SPI flash. Since coreboot is booting quite fast and especially when DEBUG_SMI is enabled causing additional delays in the PSP SMI handler, this seems to interfere with the Windows kernel or some WIndows kernel driver, causing the OS to get stuck early in the boot process somewhere between when it sends the enter ACPI mode SMI and when it starts the boot animation. Adding a 5 second delay after the boot done PSP mailbox command in case SOC_AMD_COMMON_BLOCK_PSP_SMI is selected and additional 5 seconds when DEBUG_SMI is selected too seems to makes sure that this will be done before the OS takes over which avoids the problem. The problem hasn't been fully root-cause yet, so for now this patch mainly treats the symptoms.
TEST=Now Windows 10 boots successfully every time when the PSP SMI support is enabled. Before that the first boot after power on failed due to PSP SMI flash access activity or possibly due to the PSP not being done with its flash write and RPMC activity. In subsequent boots no flash access PSP SMIs were sent from the PSP and the system booted successfully.
Change-Id: Icd4b76af829cfaa48e02da2ed224599b863af3b0 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/psp/psp.c 1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/85237/4