Attention is currently required from: Mike Banon.

Patch set 7:Code-Review -1

4 comments:

Patchset:
- Patch Set #7:
  This looks like a board/device specific hack, that cannot be generalised. Instead of modifying the pci_dev_init, why not have a PCI driver for the discrete GPU on your device with a different init function. It could even load the option rom at other available addresses, to not conflict with the VGA option ROM loading.
File src/device/pci_device.c:
- Patch Set #7, Line 749:
```
if (!CONFIG(VGA_ROM_RUN))
		return;
```
  One can assume that DISPLAY_OTHER does not decode VGA. So this makes sense.
- Patch Set #7, Line 756: PCI_CLASS_DISPLAY_OTHER
  Why not create a PCI specific driver for your device to load the option ROM without executing it. I don't think this behavior should be generalised or guarded with vague Kconfig options.
- Patch Set #7, Line 776: pci_rom_load
  This always loads the rom at 0xC0000 which is generally used for the device decoding VGA. Why not have a device specific driver to also load roms at the next option ROM address 0xD0000?

To view, visit change 38202. To unsubscribe, or for help writing mail filters, visit settings.