Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Nico Huber, Patrick Rudolph, Tim Chu.
2 comments:
File src/soc/intel/xeon_sp/chip_common.c:
Here we need to align some naming convention: stack or iio_stack?
Since we have some other functions, e.g. is_iio_pcie_stack and is_iio_cxl_stack, these type identifier is aligned to iio_stack.
For ubox, similarly, we could have is_iio_ubox_stack or is_ubox_stack.
I don't have a preference. Let us decide together :)
Patch Set #3, Line 169: soc_create_ubox_domains(dn, dev->bus, ri->BusBase, ri->BusLimit);
Can we have is_ubox_iio_stack_res() as type identifier?
From coreboot point of view, only 4 types of stack will be handled:
pcie, cxl, ubox and ioat
For type identifier of pcie and cxl, the current code base already supports
For ioat, I'm working on a PR to add (will send out soon).
To view, visit change 80091. To unsubscribe, or for help writing mail filters, visit settings.