Thanks for the replies to this patch, they have been very helpful. I now see there are some ways to make this more generic - for supporting any hotplug bridge using the HotPlug PCI slot capability as an indicator. This would also allow hotplugging to be supported correctly for U.2 devices, which again may boot without a device connected and then could have any PCIe device plugged in to them when the OS is loaded.
I have also found a nice way to emulate hotpluggable PCIe devices in QEMU:
https://github.com/qemu/qemu/blob/master/docs/pcie_pci_bridge.txt
I will work to have a more generic solution and resubmit it as a different driver, since the name thunderbolt is specific to only one technology - Thunderbolt 3 - and that will soon be obsoleted by USB 4.
View Change
To view, visit change 35946. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Duncan Laurie <dlaurie@chromium.org>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-CC: Mimoja <coreboot@mimoja.de>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Subrata Banik <subrata.banik@intel.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 14:23:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment