Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin.

Yidi Lin uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)

soc/mediatek: Add common implementation to configure display

The sequences of configure_display() are similar on MediaTek platforms.

The sequences usually involve following steps:
1. Setup mtcmos for display hardware block.
  - mtcmos_display_power_on()
  - mtcmos_protect_display_bus()
2. Configure backlight pins
3. Power on the panel
   - It also powers on the bridge in MIPI DSI to eDP case.
4. General initialization for DDP(display data path)
5. Initialize eDP/MIPI DSI accordingly,
   - For eDP path, it calls mtk_edp_init() to get edid from the panel
     and initializes eDP driver.
   - For MIPI DSI path, the edid is retrieved either from the bridge or
     from CBFS (the serializable data), and then initializes DSI driver.
6. Set framebuffer bits per pixel
7. Setup DDP mode
8. Setup panel orientation

This patch extracts geralt/display.c to mediatek/common/display.c and
refactors `struct panel_description` to generalize the display init
sequences. configure_display() is also renamed to mtk_display_init().

TEST=check FW screen on geralt.

Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f
Signed-off-by: Yidi Lin <yidilin@chromium.org>
---
M src/mainboard/google/geralt/Makefile.inc
D src/mainboard/google/geralt/display.c
M src/mainboard/google/geralt/mainboard.c
M src/mainboard/google/geralt/panel.c
M src/mainboard/google/geralt/panel.h
M src/mainboard/google/geralt/panel_geralt.c
A src/soc/mediatek/common/display.c
A src/soc/mediatek/common/include/soc/display.h
M src/soc/mediatek/mt8188/Makefile.inc
M src/soc/mediatek/mt8188/include/soc/ddp.h
10 files changed, 156 insertions(+), 151 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/79776/4

To view, visit change 79776. To unsubscribe, or for help writing mail filters, visit settings.