[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom

[Sam McNally (Code Review)]

Attention is currently required from: Felix Singer, Hsuan-ting Chen, Edward O'Callaghan, Nikolai Artemiev.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 )

Change subject: util/cbfstool: Port elogtool to libflashrom
......................................................................

Patch Set 10:

(2 comments)

File util/cbfstool/uflashrom.c:

https://review.coreboot.org/c/coreboot/+/59714/comment/a20b0462_970973a7 
PS10, Line 38: 	size_t new_size = size - offset;
> the end is padded out with flash erasure values [0xFF].

Yes, but there are calculations operating on the buffer size.

https://review.coreboot.org/c/coreboot/+/59714/comment/3728edf1_14257145 
PS10, Line 145: 		r |= flashrom_layout_include_region(layout, region);
> What is the AI you are asking for here?

Make flashrom_write() support the semantics expected of its caller (the buffer is just the region to be written)?

To do so you'd need to be able to invert resize_buf_to_nonzero_offset() here, which isn't possible without libflashrom API changes.