3 comments:
Patch Set #2, Line 13: implemention
implement*at*ion
File src/mainboard/purism/librem_cnl/romstage.c:
nit: for clarity, maybe set this to `dimm_changed`. The value is only used when `dimm_changed` is true.
Unifying both variables can't be done, since it would break the case where `load_spd_cache` fails
Patch Set #2, Line 104: cannonlake_memcfg_init(mem_cfg, &memcfg);
Wouldn't it make more sense to move the spd cache code into `cannonlake_memcfg_init`?
To view, visit change 48549. To unsubscribe, or for help writing mail filters, visit settings.