Attention is currently required from: Julius Werner.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9: When using format string with "%p", "(nil)" will be printed for address
I don't feel like we should modify coreboot's code because of printing behavior that only happens in […]
The `(nil)` is only one reason, and I already removed it from the commit message. The other reason is to make the length of printed address consistent and therefore easier to read.
To view, visit change 83652. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib29c201e1b096b9c7cd750d2541923616bc858ac
Gerrit-Change-Number: 83652
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Wed, 31 Jul 2024 01:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso@google.com>