Patrick Georgi submitted this change.
drivers/intel/fsp1_1: Drop dead MMA code
The only FSP 1.1 platform with MMA support is Skylake. As it now uses
Kaby Lake FSP 2.0, this code is no longer useful. Drop it.
Change-Id: I819c3152bdea0fdad629793d96136ef134429fbd
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51951
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
---
M src/drivers/intel/fsp1_1/Makefile.inc
D src/drivers/intel/fsp1_1/mma_core.c
2 files changed, 0 insertions(+), 40 deletions(-)
diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc
index 4259237..4b8e0a8 100644
--- a/src/drivers/intel/fsp1_1/Makefile.inc
+++ b/src/drivers/intel/fsp1_1/Makefile.inc
@@ -16,14 +16,12 @@
romstage-y += hob.c
romstage-y += raminit.c
romstage-y += romstage.c
-romstage-$(CONFIG_MMA) += mma_core.c
ramstage-y += fsp_relocate.c
ramstage-y += fsp_util.c
ramstage-y += hob.c
ramstage-y += ramstage.c
ramstage-$(CONFIG_INTEL_GMA_ADD_VBT) += vbt.c
-ramstage-$(CONFIG_MMA) += mma_core.c
CPPFLAGS_common += -Isrc/drivers/intel/fsp1_1/include
diff --git a/src/drivers/intel/fsp1_1/mma_core.c b/src/drivers/intel/fsp1_1/mma_core.c
deleted file mode 100644
index 6e50373..0000000
--- a/src/drivers/intel/fsp1_1/mma_core.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <console/console.h>
-#include <fsp/util.h>
-#include <fsp/romstage.h>
-#include <fsp/soc_binding.h>
-
-#define FSP_MMA_RESULTS_GUID { 0x8f4e928, 0xf5f, 0x46d4, \
- { 0x84, 0x10, 0x47, 0x9f, 0xda, 0x27, 0x9d, 0xb6 } }
-
-int fsp_locate_mma_results(const void **mma_hob, size_t *mma_hob_size)
-{
- const void *mma_hob_start;
- const EFI_GUID mma_results_guid = FSP_MMA_RESULTS_GUID;
-
- mma_hob_start = get_first_guid_hob(&mma_results_guid);
- if (!mma_hob_start)
- return -1;
- *mma_hob = GET_GUID_HOB_DATA(mma_hob_start);
- *mma_hob_size = GET_HOB_LENGTH(mma_hob);
-
- if (!(*mma_hob_size) || !(*mma_hob))
- return -1;
- return 0;
-}
-
-void setup_mma(MEMORY_INIT_UPD *memory_cfg)
-{
- struct mma_config_param mma_cfg;
-
- if (mma_locate_param(&mma_cfg)) {
- printk(BIOS_DEBUG, "MMA: set up failed\n");
- return;
- }
-
- soc_update_memory_params_for_mma(memory_cfg, &mma_cfg);
- printk(BIOS_DEBUG, "MMA: set up completed successfully\n");
-}
To view, visit change 51951. To unsubscribe, or for help writing mail filters, visit settings.