10 comments:
Patch Set #56, Line 10: Refactor 8173 and 8183 code, extract common API for common useage.
Refactor mt8173 and mt8183 code by extracting common API.
Please put as many words in a line as possible (without exceeding 72 characters).
Refactor rtc_read and rtc_write interface,8173 and 8183 access RTC via pmic_wrap
while 8192 via pmif
Move rtc_read and rtc_write to each SoC folder, because mt8173 and mt8183 access rtc via pmic wrapper, while mt8192 accesses it via pmif.
File src/soc/mediatek/common/rtc.c:
0 here means failure. […]
Ack. It seems like all rtc functions (except rtc_init()) are using 1 as the success return value. This is quite confusing and incompatible with the convention.
It'd be nice to upload *another* cleanup patch to fix this. See b/176307061.
File src/soc/mediatek/common/rtc_osc_init.c:
if (val > RTC_FQMTR_LOW_BASE)
diff1 = val - RTC_FQMTR_LOW_BASE;
else
diff1 = RTC_FQMTR_LOW_BASE - val;
Ack
Not done.
File src/soc/mediatek/mt8173/rtc.c:
Patch Set #56, Line 20: /* export 32K clock RTC_32K2V8 */
Since this is irrelevant, let's keep it unchanged.
Patch Set #56, Line 78: /* use SW to detect 32K mode instead of HW */
Since this is irrelevant, let's keep it unchanged.
File src/soc/mediatek/mt8192/rtc.c:
%#x
Maybe %#x?
Add a blank line before this.
failed
To view, visit change 46395. To unsubscribe, or for help writing mail filters, visit settings.