2 comments:
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:
Patch Set #2, Line 32: * | |X86_RESET_VECTOR = ROMSTAGE_ADDR + ROMSTAGE_SIZE - 0x10
Is this correct?
There is assert on:
BOOTBLOCK_ADDR + C_ENV_BOOTBLOCK_SIZE - 0x10 == X86_RESET_VECTOR
Patch Set #2, Line 85: _ = ASSERT((CONFIG_BOOTBLOCK_ADDR + CONFIG_C_ENV_BOOTBLOCK_SIZE - 0x10) == CONFIG_X86_RESET_VECTOR, "Reset vector should be -0x10 from end of bootblock");
The assertion here reveals redundancy in the use of Kconfigs. You do not need to define X86_RESET_VECTOR separately. Also X86_RESET_VECTOR help text forgets to mention there is architectural requirement for the address to end with 0xfff0.
To view, visit change 47828. To unsubscribe, or for help writing mail filters, visit settings.