Patch Set 2:

Patch Set 2:

not that it makes a big difference here, but is the SIO part of the ast2400 behind a PCI(e) device or is it connected to the LPC bus?

It's connected to PCIe, LPC and USB.

Logically, I believe SIO must be on LPC; PCI bridges only forward IO transactions that fall within the (configured) IO window in PCI configuration register space.

View Change

To view, visit change 32984. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86af69c6b2ccefe2c88eef875bc858239df834f1
Gerrit-Change-Number: 32984
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Sat, 25 May 2019 07:54:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment