2 Apr
2019
2 Apr
'19
9:55 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32142 )
Change subject: ec/google/chromeec: Remove redundant use of ACPI offset operator ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl@a... PS2, Line 90: Looking back at this, it seems like this was done to ensure that we don't overrun the device features. Probably we can add DUMY, 1 after Offset(0x0e) to maintain the original intent. Thoughts?
Also adding Patrick who had added this code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32142
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedf67f1caafa9627491e8b8f91be69b551d07ae8
Gerrit-Change-Number: 32142
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 19:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment