Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36945 )
Change subject: mb/google/kahlee/treeya: Make sure touchpad data hold time more than 300ns ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@8 PS1, Line 8: than 300ns The commit message summary must go on one line. Maybe (whatever “touchpad data hold time” is):
Hold touchpad data 400 ns
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@10 PS1, Line 10: need tune need to tune
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@10 PS1, Line 10: SI What does that mean?
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@11 PS1, Line 11: more than 300ns Why do you increase it to 400 ns then?
What is the default value?
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@14 PS1, Line 14: TEST=build firmware and masure I2C bus2 data hold time How did you measure it?
https://review.coreboot.org/c/coreboot/+/36945/1//COMMIT_MSG@14 PS1, Line 14: masure measure