Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email )
Change subject: src: Implement framework for PRERAM VSD store ......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS10:
- ISH firmware version which needs to be passed between romstage and ramstage […]
Sorry, I still disagree with this whole "VSD" thing and the extra APIs you add for it. I don't see how they serve a purpose. CBMEM is already an allocator that can give you a data area of your preferred size. You don't need to add another API that's just "give me an area of size X" and all it does is chain that call to cbmem_add().
We agreed that pre-RAM CBMEM sounds like a good eventual long-term goal, and that it would take too long right now so you need a temporary stopgap solution instead. So please, for that temporary solution, just use a global variable. I agree that having everything floating around in global variables may get unwieldy long term, but that's why the solution is temporary. You don't need to design a big new temporary "VSD" API just so we can eventually throw it away again and do pre-RAM CBMEM instead. Don't over-engineer a stopgap, just do the simplest thing.