Patch Set 4:

Just curious, why would we want to make it explicit entry in car.ld when using .bss should achieve just the same?

Isn't that more meaningful now to know why we are reserving that block in car.ld?

View Change

10 comments:

• Commit Message:

  • Patch Set #4, Line 27: stack

    heap

    Done

• File src/arch/x86/car.ld:

  • Patch Set #4, Line 96: CONFIG_C_ENVIRONMENT_BOOTBLOCK

    Yeah, having this space should be independent.

    Done

  • Patch Set #4, Line 102: CONFIG_DCACHE_BSP_HEAP_SIZE

    Put 'FSP' in the name since it has only to do w/ FSP. Same for the symbols -- add 'fsp' in there.

    Done

• File src/arch/x86/include/arch/symbols.h:

  • Patch Set #4, Line 64: _car_heap_start - _car_heap_end

    Isn't this inverted?

    my bad

• File src/cpu/Kconfig:

  • Patch Set #4, Line 28: depends on FSP_USES_CB_STACK

    maybe FSP_DCACHE_HEAP_SIZE ?

    Done

• File src/drivers/intel/fsp2_0/memory_init.c:

  • Patch Set #4, Line 164: setup_fsp_stack_frame

    Doing this in setup_fsp_stack_frame() makes it confusing. […]

    Done

  • Patch Set #4, Line 178: stack

    heap?

    Done

  • Patch Set #4, Line 188: FSP stack base

    Agreed, it shouldn't be called out specifically, as it's no longer separate.

    Done

  • Patch Set #4, Line 189: vboot

    I understand the intent here to add vboot to provide a complete picture of the memory layout. […]

    Done

  • Patch Set #4, Line 196: arch_upd->StackSize = CONFIG_DCACHE_BSP_HEAP_SIZE;

    Please use symbol macros for size.

    Done

To view, visit change 35165. To unsubscribe, or for help writing mail filters, visit settings.