View Change
2 comments:
Commit Message:
Patch Set #2, Line 9: Always select USE_LEGACY_8254_TIMER if we know we have to.
This patchset changes default of USE_LEGACY_8254_TIMER to Y unconditional. […]
It also selects USE_LEGACY_8254_TIMER in specific cases to prevent a hang.
File src/device/Kconfig:
Patch Set #2, Line 89: select USE_LEGACY_8254_TIMER if SOC_INTEL_COMMON_BLOCK
Should this be enabled for VGA Oprom only? Or for all Oproms?
It should be enabled for all Oproms, but we only support VGA Oproms in coreboot.
To view, visit change 34709. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0c20255f661dd61edc3a7d15646b7447c4658e
Gerrit-Change-Number: 34709
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Frans Hendriks <fhendriks@eltan.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-MessageType: comment