Attention is currently required from: Jason Nien, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70215 )
Change subject: google/skyrim/Kconfig: Enable DPTC for Frostflow
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm assuming the STT params are all set?
Yeah. I moved everything to the base `devicetree.cb` with this CL:
69904: mb/google/skyrim: Move common DPTC values to devicetree.cb | https://review.coreboot.org/c/coreboot/+/69904
That should give everything a starting point, which can be tuned in the appropriate `overridetree.cb`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fb5c711a01a995c805eb4509f7b04bb41588365
Gerrit-Change-Number: 70215
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 18:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment