Done with most of comments, I just need some answers for some files and I think it starts to be good
Patch set 15:Code-Review +1
19 comments:
Patch Set #14, Line 7: mb/ongy/h61m-s1: Add new mainboard
Add an empty line between the commit summary and the commit message: […]
Done
Patch Set #14, Line 15: Integrated VGA and HDMI works
Was this with libgfxinit? (the default graphics init for most Intel iGPUs)
Yes, I mentioned it in a new version of this file
Patch Set #14, Line 17: Seabios
SeaBIOS
Done
File src/mainboard/ongy/h61m-s1/Kconfig:
config VGA_BIOS_FILE
string
default "pci8086,0112.rom"
config VGA_BIOS_ID
string
default "8086,0112"
Remove this, it depends on the installed CPU
Done
onfig DRAM_RESET_GATE_GPIO
int
default 60
This is not correct. GPIO60 is configured as native mode on your board. […]
Done
File src/mainboard/ongy/h61m-s1/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
This does nothing. […]
So must I remove all line and let a blank function or revmove everthing an let an empty file?
File src/mainboard/ongy/h61m-s1/devicetree.cb:
register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_dp_b_hotplug" = "4"
register "gpu_dp_c_hotplug" = "4"
register "gpu_dp_d_hotplug" = "4"
register "gpu_panel_power_cycle_delay" = "4"
These settings aren't needed for a desktop board
Done
0
Done
0
Done
0
Done
Patch Set #14, Line 25: register "docking_supported" = "0"
This defaults to zero already. […]
Done
Patch Set #14, Line 27: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
This defaults to zero already. […]
Done
device pci 00.0 on # Host bridge Host bridge
subsystemid 0x8086 0x0100
end
device pci 01.0 on # PEG
subsystemid 0x8086 0x0101
end
device pci 02.0 on # iGPU
subsystemid 0x8086 0x2010
end
Please move these entries above the southbridge block. That is, before this line: […]
Done
File src/mainboard/ongy/h61m-s1/dsdt.asl:
Patch Set #10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
It's only used on Lenovo mainboards. […]
Done
File src/mainboard/ongy/h61m-s1/dsdt.asl:
Patch Set #14, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Unused, can remove
Done
Capitalize: "Global"
Done
Patch Set #14, Line 29: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Not needed for a desktop board without an integrated panel
Done
File src/mainboard/ongy/h61m-s1/gma-mainboard.ads:
Patch Set #14, Line 10: private package GMA.Mainboard is
Almost all the gma_mainboard.ads files in coreboot are indented with three spaces, instead of tabs. […]
Done (I think :-) )
File src/mainboard/ongy/h61m-s1/mainboard.c:
If you don't plan on using the VGA BIOS, I would remove this and the `select INTEL_INT15` line from […]
You mean remove everything? My first build was with libgfxinit indeed
To view, visit change 40813. To unsubscribe, or for help writing mail filters, visit settings.