3 comments:
File src/include/device/smbus_host.h:
Patch Set #5, Line 31: /* Only since ICH5 */
This comment is kind of odd now that it's outside `intel` scope
Done
File src/southbridge/intel/common/smbus.c:
Patch Set #5, Line 336: smbus_base
This name does not match that of the declaration in `smbus_host. […]
CB:38305
Patch Set #5, Line 383: int do_smbus_block_write(uintptr_t smbus_base, u8 device, u8 cmd, const size_t bytes, const u8 *buf)
Can fix this by using the same parameter names as in the declarations. […]
CB:38305
To view, visit change 38226. To unsubscribe, or for help writing mail filters, visit settings.