Attention is currently required from: Tim Crawford, Cliff Huang, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60183 )
Change subject: soc/intel/common/block/pcie/rtd3: Update ACPI methods for CPU PCIe RPs ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60183/comment/a78b99cc_7f51b003 PS4, Line 10: next line may be?
https://review.coreboot.org/c/coreboot/+/60183/comment/71f4f54f_b77d94f6 PS4, Line 12: can you please also highlight here that you have dropped unused argument from pcie_rtd3_acpi_method_status() or you consider to submit that in a separate CL?
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/60183/comment/de0b2161_aea0e598 PS4, Line 269: /* Read port number of root port that this device is attached to. */ : pcie_rp = pci_read_config8(parent, PCH_PCIE_CFG_LCAP_PN); : if (pcie_rp == 0 || pcie_rp > CONFIG_MAX_ROOT_PORTS) { : printk(BIOS_ERR, "%s: Invalid root port number: %u\n", __func__, pcie_rp); : return; : } : /* Port number is 1-based, PMC IPC method expects 0-based. */ : pcie_rp--; suggestion: can you please consider creating a static helper function that return the pch pci_rp number?