Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33235 )
Change subject: cpu/x86/smm/ STM Support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 139: #ifdef CONFIG_STM
no need for preprocessor
Done
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 178: MsegChk = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX);
delay the printk after console_init(). So you don't need to call it twice.
Done
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_stub.S@51 PS1, Line 51: /* allows the STM to bring up SMM in 32-bit mode*/
seems unsued
This variable is consumed in smm_handler_start as part of the STM/MSEG initialization