[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp/Makefile: warn when FSP files aren't specified

[Furquan Shaikh (Code Review)]

Attention is currently required from: Nico Huber, Andrey Petrov, Patrick Rudolph, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57219 )

Change subject: drivers/intel/fsp/Makefile: warn when FSP files aren't specified
......................................................................

Patch Set 1: Code-Review+2

(3 comments)

File src/drivers/intel/fsp2_0/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/57219/comment/abbae5aa_6e50fcec 
PS1, Line 101: CONFIG_FSP_T_FILE
> CB:57220 […]

Ack

https://review.coreboot.org/c/coreboot/+/57219/comment/d255c082_2f73a4ea 
PS1, Line 102: warning
> wasn't sure if this will break some case, so i made this print a warning and not throw an error

It might make sense to make this an error. If ADD_FSP_BINARIES are set and the files are not provided, then it is an invalid condition.

https://review.coreboot.org/c/coreboot/+/57219/comment/2de18c4a_aad2c3fb 
PS1, Line 105: $(call strip_quotes,$(CONFIG_FSP_M_FILE))
> no, FSP_M_CBFS is the result of calling strip_quotes on CONFIG_FSP_M_CBFS, not CONFIG_FSP_M_FILE

Ack.